Contributors

muka

Hello @muka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/ambianic/__init__.py:

Line 30:65: W291 trailing whitespace

• In the file src/ambianic/notification.py:

Line 12:1: E302 expected 2 blank lines, found 1
Line 13:29: E231 missing whitespace after ':'
Line 13:53: E231 missing whitespace after ':'
Line 13:74: E231 missing whitespace after ':'
Line 13:80: E501 line too long (90 > 79 characters)
Line 39:69: W291 trailing whitespace
Line 40:29: E131 continuation line unaligned for hanging indent
Line 49:78: E202 whitespace before ')'
Line 67:80: E501 line too long (88 > 79 characters)
Line 82:1: W293 blank line contains whitespace
Line 85:25: W291 trailing whitespace
Line 87:30: W291 trailing whitespace
Line 92:55: W291 trailing whitespace
Line 97:27: E128 continuation line under-indented for visual indent

• In the file src/ambianic/pipeline/store.py:

Line 71:1: W293 blank line contains whitespace
Line 74:42: W291 trailing whitespace
Line 75:80: E501 line too long (94 > 79 characters)
Line 198:80: E501 line too long (99 > 79 characters)

• In the file tests/pipeline/test_notify.py:

Line 18:19: E231 missing whitespace after ':'
Line 20:5: E301 expected 1 blank line, found 0
Line 33:1: E302 expected 2 blank lines, found 1
Line 40:1: E302 expected 2 blank lines, found 1
Line 48:1: W293 blank line contains whitespace
Line 76:1: E302 expected 2 blank lines, found 1
Line 113:1: E302 expected 2 blank lines, found 1
Line 115:11: E231 missing whitespace after ':'
Line 131:35: E231 missing whitespace after ','

Comment last updated at 2020-12-31 17:34:11 UTC

Codecov Report

Merging #276 (ef46195) into master (abcd853) will decrease coverage by 0.26%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   94.02%   93.76%   -0.27%     
==========================================
  Files          21       22       +1     
  Lines        2010     2084      +74     
==========================================
+ Hits         1890     1954      +64     
- Misses        120      130      +10     

Maybe not 100% ready yet but time for a first round of review :)

@muka LGTM. I have no further comments. Do you want me to merge now or have more to do on this PR?

We are good to go for me, thanks

Alright. Happy New 2021 PR merge!

🎉 This PR is included in version 1.12.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀